Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Improvements to Admin Infected commands #159

Open
Tiagoquix opened this issue May 14, 2024 · 7 comments
Open

[Feature request] Improvements to Admin Infected commands #159

Tiagoquix opened this issue May 14, 2024 · 7 comments

Comments

@Tiagoquix
Copy link
Contributor

Hello there.

Currently, when using the sm_tank command, it seems that the person who executed the commands is always chosen to be the tank if he or she is in the Zombies team.

I would like to request that the sm_tank command to choose a random Zombie player instead of choosing the person that executed the command.

Also, if possible, I would like to also request to add support for admins to force a player to be a tank with sm_tank <player name/#user ID>.

Thanks in advance.

@FortyTwoFortyTwo
Copy link
Member

I would like to request that the sm_tank command to choose a random Zombie player instead of choosing the person that executed the command.

There is szf_zombietank command that exactly does that, but I do agree it's quite odd for sm_tank to function differently and is based on whoever executed it.

Also, if possible, I would like to also request to add support for admins to force a player to be a tank with sm_tank <player name/#user ID>.

sm_infected command works on tanks the same way as force setting someone an infected, command could be clarified a bit that it works on tank.

@Tiagoquix
Copy link
Contributor Author

Tiagoquix commented May 15, 2024

Hi there. I think we could do the following:

Which commands does what?

  • sm_zombietank and sm_tank would do the same thing.
  • sm_zombieinfected, sm_zombie and sm_infected would do the same thing.
  • Create aforementioned commands if they don't exist.

When used WITHOUT arguments:

  • sm_tank would force a random BLU player to be turned into a Tank in their next respawn.
  • sm_zombie would force a random RED player to instantly die and to be turned into a random Common or Special Infected.

When used WITH arguments:

  • sm_tank, when used with an argument consisting of a player name or user ID, will turn that player into a Tank in their next respawn.
  • sm_zombie, when used with an argument consisting of a player name or user ID and the type of Zombie (Hunter, Jockey, Smoker etc.), will turn that player into the specified Infected type immediately.
  • For both commands: if the specified person is a RED player or is in Spectator mode, the command does not work and outputs an error.

@Tiagoquix Tiagoquix changed the title [Feature request] Change logic of sm_tank command [Feature request] Improvements to Admin Infected commands May 15, 2024
@Tiagoquix
Copy link
Contributor Author

By the way, I'm not entirely sure if this is already the case, but, if possible, I would like such messages from "Called tank." and other informative messages were visible only to those who executed the command, without making it visible to the players that there was administrative intervention.

From my limited knowledge of SourcePawn, having read the code, this behavior seems to already apply to "Called tank.", but I don't know if it applies to other commands (such as sm_rage and sm_stun).

@Tiagoquix
Copy link
Contributor Author

Tiagoquix commented May 15, 2024

Now I realize you mentioned "szf_zombietank", not "sm_zombietank". Reading the code, they are "server commands" rather than administrative commands. How does this differ in practice?

@Mikusch
Copy link
Member

Mikusch commented May 15, 2024

Means they can only be executed from server console (or done via sm_rcon). I don't think anyone really put much thought into these as they were mostly put in for development purposes

@FortyTwoFortyTwo
Copy link
Member

sm_tank, when used with an argument consisting of a player name or user ID, will turn that player into a Tank in their next respawn.

It can be done, just that it'll only accept one user

By the way, I'm not entirely sure if this is already the case, but, if possible, I would like such messages from "Called tank." and other informative messages were visible only to those who executed the command, without making it visible to the players that there was administrative intervention.

It already only shows to whoever executes it, unless I'm missing some other commands.

From my limited knowledge of SourcePawn, having read the code, this behavior seems to already apply to "Called tank.", but I don't know if it applies to other commands (such as sm_rage and sm_stun).

Is there a reason to have one for rage if a global message were to be shown anyway?

@Tiagoquix
Copy link
Contributor Author

It can be done, just that it'll only accept one user

Sure then!

It already only shows to whoever executes it, unless I'm missing some other commands.

I don't know if the other commands have a message too.

Is there a reason to have one for rage if a global message were to be shown anyway?

Maybe to differentiate from the timed one and the admin-forced one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants