Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser and OS tabs are disabled #42

Open
tomharvey opened this issue Sep 4, 2023 · 4 comments
Open

Browser and OS tabs are disabled #42

tomharvey opened this issue Sep 4, 2023 · 4 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@tomharvey
Copy link

No description provided.

@rehanvdm
Copy link
Owner

rehanvdm commented Sep 5, 2023

This is because we don't store that data yet. It would have to be added here. Within that function you can extract the OS and Browser in similar ways.

The bigger question is whether these two fields are actually worth storing. I know I don't use that data, but knowing the OS and Browser does not add ad a lot of value to me. But others might find this useful? The idea is to not just track every variable that we possibly can because it will inflate the record size. So I only want to track what brings value.

I intentionally made them disabled to see if someone queries about them like now :)

So if you feel that these stats are useful, by all means, submit a PR. Or let's wait to see if others would also like/find int useful. But for now, this is lower down on the priority list.

@rehanvdm rehanvdm added this to Roadmap Sep 5, 2023
@rehanvdm rehanvdm added the enhancement New feature or request label Sep 5, 2023
@tomharvey
Copy link
Author

Honestly, not sure I would use them either :) Just wondering why they were disabled.

@github-project-automation github-project-automation bot moved this to Done in Roadmap Sep 8, 2023
@rehanvdm rehanvdm added the question Further information is requested label Sep 9, 2023
@rehanvdm rehanvdm reopened this Sep 9, 2023
@rehanvdm
Copy link
Owner

rehanvdm commented Sep 9, 2023

Let's actually leave this open. Anyone that wants to see this please +1.

Otherwise, I think we should remove those 2 tabs and replace with "Humans VS. Bots". Because we do have that metric and I have been wanting to surface it. Maybe just the same as the others. so a table, or a donut chart.

@rehanvdm
Copy link
Owner

rehanvdm commented Sep 9, 2023

This is the ticket for that #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Status: Done
Development

No branches or pull requests

2 participants