You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While addressing some automated code complexity warnings over on #168 I noticed that the check for variation_type for ClinVar is correctly executed but there is no following continue instruction that would lead to filtering out non-SNV variants:
However, it appears likely that they are not included either way, because there is another filter earlier in the pipeline, when the mutations are mapped with annovar:
krassowski
changed the title
Status of ClinVar variation != "single nucleotide variant" in ADDB 2019+ versions
ClinVar variation != "single nucleotide variant" in ADDB 2019+ versions
Mar 7, 2021
krassowski
changed the title
ClinVar variation != "single nucleotide variant" in ADDB 2019+ versions
ClinVar variation != "single nucleotide variant" in ADDB 2019+
Mar 7, 2021
While addressing some automated code complexity warnings over on #168 I noticed that the check for
variation_type
for ClinVar is correctly executed but there is no followingcontinue
instruction that would lead to filtering out non-SNV variants:ActiveDriverDB/website/imports/mutations/clinvar.py
Lines 257 to 261 in 5e9d2c3
However, it appears likely that they are not included either way, because there is another filter earlier in the pipeline, when the mutations are mapped with annovar:
ActiveDriverDB/website/data/mutations/annotate_clinvar.sh
Line 10 in cc4873a
It would be good to investigate this further. For now, I will add a TODO note in the code to highlight this issue.
The text was updated successfully, but these errors were encountered: