Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The validity of Ruby symbols as EDN keywords is not checked before conversion #6

Open
cndreisbach opened this issue Sep 12, 2012 · 2 comments

Comments

@cndreisbach
Copy link
Contributor

We should be doing this, and doing it with EDN::Type::Symbols as well.

@yokolet
Copy link
Contributor

yokolet commented Dec 21, 2012

So, you mean there's a case Ruby symbol should not be simply mapped to EDN::Type::Symbol type, right? If so, what is the case?

@cndreisbach
Copy link
Contributor Author

Ruby symbols can have anything in them by quoting them, like this: `:"hello i am a symbol". That would not be a valid Clojure keyword. I'm not sure what the best solution is. I would consider throwing an exception in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants