Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : #4 user role, penalty 도메인 작성 및 user 조회 전략 일괄 수정 #8

Merged
merged 9 commits into from
Nov 1, 2020
Merged

feat : #4 user role, penalty 도메인 작성 및 user 조회 전략 일괄 수정 #8

merged 9 commits into from
Nov 1, 2020

Conversation

sehajyang
Copy link
Member

작성한 도메인

  • Role
  • Penalty
  • UserPenalty
    리뷰 부탁드립니다 :)

@sehajyang sehajyang requested a review from parkhuiwo0 October 15, 2020 05:04
@sehajyang
feat : #4 User 조회 생성 API 작성 및 H2 설정 추가
9bbbf96 
* findAll, create, validation 작성
* H2 config 작성
* UserDTO 작성
@parkhuiwo0
Copy link
Member

이번주 안으로 리뷰 끝

@sehajyang
feat : #5 api response 작성
cbecfbd
@sehajyang
feat : #5 ExceptionHandler 작성
30386d5 
* ExceptionHandler
* ErrorResponse
* CustomException 
* ExceptionType
* Message Component
@sehajyang sehajyang self-assigned this Oct 31, 2020
This was linked to issues Oct 31, 2020
resume domain entity 만들기 #3
Open
user 도메인 작성 #4
Closed
공통 utils 작성 #5
Open
@sehajyang
fix : CustomException handling return 값 변경
edc7f01 
* messageComponent return StringUtil로 isEmpty 체크하도록 수정
* Error Response 생성자 파라미터 타입 변경
@sehajyang sehajyang merged commit 9e50b8e into develop Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkhuiwo0 parkhuiwo0 Awaiting requested review from parkhuiwo0

Assignees

@sehajyang sehajyang

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

공통 utils 작성 resume domain entity 만들기 user 도메인 작성
2 participants
@sehajyang @parkhuiwo0