From 372895630344f52afb9aaed1f9d96bbd682987e7 Mon Sep 17 00:00:00 2001 From: Rob Hogan Date: Thu, 28 Mar 2024 03:28:24 -0700 Subject: [PATCH] Feature flags: Enable modern inspector Differential Revision: D54804534 --- .../featureflags/ReactNativeFeatureFlagsDefaults.kt | 6 +++--- .../react/featureflags/ReactNativeFeatureFlagsDefaults.h | 6 +++--- .../scripts/featureflags/ReactNativeFeatureFlags.config.js | 4 ++-- .../src/private/featureflags/ReactNativeFeatureFlags.js | 6 +++--- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt index 5931f315b793dc..ca1acc60ae3ffe 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<> + * @generated SignedSource<<4144a14f12d092ef5e6f98b54d5ddb36>> */ /** @@ -43,9 +43,9 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi override fun enableUIConsistency(): Boolean = false - override fun inspectorEnableCxxInspectorPackagerConnection(): Boolean = false + override fun inspectorEnableCxxInspectorPackagerConnection(): Boolean = true - override fun inspectorEnableModernCDPRegistry(): Boolean = false + override fun inspectorEnableModernCDPRegistry(): Boolean = true override fun useModernRuntimeScheduler(): Boolean = false } diff --git a/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h b/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h index b9ff005fd37c86..a9266fe7c9f5b2 100644 --- a/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h +++ b/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<<9fd009411ce19224a3102d2713b0b042>> + * @generated SignedSource<<30ed120ea566c492b69310d3dbdbc0d2>> */ /** @@ -68,11 +68,11 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider { } bool inspectorEnableCxxInspectorPackagerConnection() override { - return false; + return true; } bool inspectorEnableModernCDPRegistry() override { - return false; + return true; } bool useModernRuntimeScheduler() override { diff --git a/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js b/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js index 396d3290700157..b4cf3f9690c470 100644 --- a/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js +++ b/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js @@ -78,12 +78,12 @@ const definitions: FeatureFlagDefinitions = { 'Ensures that JavaScript always has a consistent view of the state of the UI (e.g.: commits done in other threads are not immediately propagated to JS during its execution).', }, inspectorEnableCxxInspectorPackagerConnection: { - defaultValue: false, + defaultValue: true, description: 'Flag determining if the C++ implementation of InspectorPackagerConnection should be used instead of the per-platform one. This flag is global and should not be changed across React Host lifetimes.', }, inspectorEnableModernCDPRegistry: { - defaultValue: false, + defaultValue: true, description: 'Flag determining if the modern CDP backend should be enabled. This flag is global and should not be changed across React Host lifetimes.', }, diff --git a/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js b/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js index 2e642c0017e1ee..50ae15d13677bd 100644 --- a/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js +++ b/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<<366b36d877532c93aa6e5a97b85edd06>> + * @generated SignedSource<<0b32023eeca560b015d00f5e9d896a95>> * @flow strict-local */ @@ -138,11 +138,11 @@ export const enableUIConsistency: Getter = createNativeFlagGetter('enab /** * Flag determining if the C++ implementation of InspectorPackagerConnection should be used instead of the per-platform one. This flag is global and should not be changed across React Host lifetimes. */ -export const inspectorEnableCxxInspectorPackagerConnection: Getter = createNativeFlagGetter('inspectorEnableCxxInspectorPackagerConnection', false); +export const inspectorEnableCxxInspectorPackagerConnection: Getter = createNativeFlagGetter('inspectorEnableCxxInspectorPackagerConnection', true); /** * Flag determining if the modern CDP backend should be enabled. This flag is global and should not be changed across React Host lifetimes. */ -export const inspectorEnableModernCDPRegistry: Getter = createNativeFlagGetter('inspectorEnableModernCDPRegistry', false); +export const inspectorEnableModernCDPRegistry: Getter = createNativeFlagGetter('inspectorEnableModernCDPRegistry', true); /** * When enabled, it uses the modern fork of RuntimeScheduler that allows scheduling tasks with priorities from any thread. */