Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the oblate model #290

Open
3 tasks
rodluger opened this issue Sep 2, 2021 · 0 comments
Open
3 tasks

Improvements to the oblate model #290

rodluger opened this issue Sep 2, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@rodluger
Copy link
Owner

rodluger commented Sep 2, 2021

Several improvements can be made to the oblate transit model (starry.Map(oblate=True)):

  • Implement the general quartic solver for arbitrary size occultors. The current algorithm can only model cases where there are up to two points of intersection between the limbs of the two bodies. If the star is very oblate or if the occultor is large (such as a companion star), there can be up to four points of intersection, with four separate curves comprising the boundary of the occulted region. This requires a bit of re-structuring of the algorithm on the C++ side, but it's not conceptually difficult.
  • Prior to implementing the general case, we should add checks for the condition fproj >= 1 - sqrt(ro) (where fproj is the projected oblateness and ro is the planet-star radius ratio). When this condition is satisfied, occultations with four points of intersection are possible. Raise an error on the theano side when this happens.
  • Secondary eclipses are currently not modeled correctly: if the star is oblate and a planet gets occulted by it, the present algorithm ignores the oblateness. It shouldn't be too hard to solve the problem correctly. In the meantime, raise a warning when this happens.
@rodluger rodluger added the enhancement New feature or request label Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant