Skip to content
This repository has been archived by the owner on Dec 28, 2019. It is now read-only.

The OdinMS inventory issue. #125

Open
UltimateMors opened this issue Nov 8, 2017 · 3 comments
Open

The OdinMS inventory issue. #125

UltimateMors opened this issue Nov 8, 2017 · 3 comments

Comments

@UltimateMors
Copy link
Contributor

I'm connecting this to issue #122. Because I know this has been a problem since 2007. Where the creators of OdinMS thought it would be an good idea to delete all of the items in the inventory in order to reload them or some sort.

I know multiple servers have not fixed this, even the top servers that are around today. Is there a possible way to fix this? It's a very serious problem, because if a person disconnects while items are getting re-loaded, the whole inventory can be deleted.

@ronancpl
Copy link
Owner

ronancpl commented Nov 8, 2017

I'm acknowledged of this issue. As matter of fact, to have a private server properly deployed for production (to host a server that is), this one recorrent problem would have to be managed beforehand. Anyone inclined to help on this task is most welcome, by sending a PR here.

@ronancpl
Copy link
Owner

ronancpl commented Nov 8, 2017

To solve this, what needs to be done is a refactor on the load and save data queries, to prevent deleting then reinserting redundant rows on the tables and, instead, make it update these redundant rows, deleting or adding only those that are really necessary.

@tylerhasman
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants