Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping css file #24

Open
eirikurn opened this issue Oct 19, 2017 · 2 comments
Open

Skipping css file #24

eirikurn opened this issue Oct 19, 2017 · 2 comments

Comments

@eirikurn
Copy link
Contributor

For js-in-css projects, we don't want a css file for components. Would be nice to have a project setting to skip that, like we can already skip the tests.

@rthor
Copy link
Owner

rthor commented Oct 20, 2017

Good point! I'm wondering if the correct way to go about this would be to rename the "cssExtension" property to "css" and accept false as a value, in addition to css extension strings. Eg

interface OptionsT {
  [otherOptions: string]: any,
  css: false | string,
}

This way we support both and could pass correct overrides in the cli:

cra-generate Foo --css=false

@eirikurn
Copy link
Contributor Author

eirikurn commented Oct 20, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants