-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staff Create Pet: add tooltips to the published and paused applications toggles #1220
Comments
Can I work on this one @kasugaijin ? |
For sure all yours @mgrigoriev8109 |
* feat: add alert when missing attachment * fix: adjust equality * fix: broken tests, rename variables and method * refactor: use present? instead of nil? * refactor: change no_empty_images to images and files * chore: add comment on why we remove empty string from files / images array
Unassigning myself from this if anyone else wants to work on it - assuming no one else has implemented actual responsive tooltips yet, I think the temporary fix we want to have is to include those two messages in parenthesis next to the Switch buttons. |
@kasugaijin I think actually you can just change the labels to avoid the tooltip. "Application Paused" -> "Accepting new adoption applications" Sometimes I think we can add a bit more details in the toggle to make it more clear rather than go for the tooltip where you'd have to dive into the tooltip to understand. |
@edwinthinks yes we went with modified labels a s a workaround in the meantime. The tooltip is definitely a nice to have, and you're right, to be used cautiously. |
@kasugaijin yeh tooltips is good but I don't often think people use them to learn more about anything. Would be a good additional touch if you find people don't know what those mean. |
These two toggles might not be intuitive to understand what they are for, so it would be good to add an icon and tooltip description for each. See an example of a tooktip in action on our theme here (for password strength): https://geeksui.codescandy.com/geeks/pages/security.html
Application Paused: 'If applications are paused, the public can see the pet but cannot submit an adoption application.'
Published: 'If a pet is published it is visible to the public.'
The text was updated successfully, but these errors were encountered: