Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staff Create Pet: add tooltips to the published and paused applications toggles #1220

Open
kasugaijin opened this issue Dec 8, 2024 · 6 comments

Comments

@kasugaijin
Copy link
Collaborator

kasugaijin commented Dec 8, 2024

These two toggles might not be intuitive to understand what they are for, so it would be good to add an icon and tooltip description for each. See an example of a tooktip in action on our theme here (for password strength): https://geeksui.codescandy.com/geeks/pages/security.html

Application Paused: 'If applications are paused, the public can see the pet but cannot submit an adoption application.'
Published: 'If a pet is published it is visible to the public.'

image
@kasugaijin kasugaijin added the Ready Make a comment to get assigned. label Dec 8, 2024
@mgrigoriev8109
Copy link
Contributor

Can I work on this one @kasugaijin ?

@kasugaijin
Copy link
Collaborator Author

For sure all yours @mgrigoriev8109

@kasugaijin kasugaijin removed the Ready Make a comment to get assigned. label Dec 16, 2024
kasugaijin pushed a commit that referenced this issue Dec 26, 2024
* feat: add alert when missing attachment

* fix: adjust equality

* fix: broken tests, rename variables and method

* refactor: use present? instead of nil?

* refactor: change no_empty_images to images and files

* chore: add comment on why we remove empty string  from files / images array
@mgrigoriev8109 mgrigoriev8109 removed their assignment Dec 27, 2024
@mgrigoriev8109
Copy link
Contributor

Unassigning myself from this if anyone else wants to work on it -

assuming no one else has implemented actual responsive tooltips yet, I think the temporary fix we want to have is to include those two messages in parenthesis next to the Switch buttons.

@edwinthinks
Copy link
Collaborator

edwinthinks commented Dec 28, 2024

@kasugaijin I think actually you can just change the labels to avoid the tooltip.

"Application Paused" -> "Accepting new adoption applications"
"Published" -> "Pet visible to public?"

Sometimes I think we can add a bit more details in the toggle to make it more clear rather than go for the tooltip where you'd have to dive into the tooltip to understand.

@kasugaijin
Copy link
Collaborator Author

@edwinthinks yes we went with modified labels a s a workaround in the meantime. The tooltip is definitely a nice to have, and you're right, to be used cautiously.

@edwinthinks
Copy link
Collaborator

@kasugaijin yeh tooltips is good but I don't often think people use them to learn more about anything. Would be a good additional touch if you find people don't know what those mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants