Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to include in-kind values in export of donations and distributions #4858

Open
3 tasks
cielf opened this issue Dec 15, 2024 · 6 comments · May be fixed by #4897
Open
3 tasks

Add an option to include in-kind values in export of donations and distributions #4858

cielf opened this issue Dec 15, 2024 · 6 comments · May be fixed by #4897
Labels

Comments

@cielf
Copy link
Collaborator

cielf commented Dec 15, 2024

Summary

Add an option to include in-kind totals for each item in exports of donations and distributions

Details

  • Add an option on the organization level to include in-kind values in exports of donations and distributions - Label: "Include in-kind value in donation and distribution exports?' Default it to no. The question shsould go before Distribution Email Content on the organization view/edit,
  • Adjust donation export to include in-kind totals for each item on each donation, interleaved with the item quantities, when that option is true
  • Adjust distribution export to include in-kind totals for each item on each distribution, interleaved with the item quantities, when that option is true

Origin

Feature request from Austin Diaper Bank, see support channel starting Sept 15, 2024.

Criteria for completion

  • tests to support above behaviour
  • behaviour as described above
  • update user manual to reflect above behaviour

Notes

We checked with the stakeholder circle, and this should definitely be an opt-in, rather than an all-banks thing.

@nozomirin
Copy link
Contributor

I don’t fully understand the "In-Kind totals" you mentioned.
There is an "In-Kind Value" column in the exported donation file. Should it be renamed to "In-Kind Total"?

There should be a switch in the "My Organization" page to control whether the exported file includes in-kind value of each item. When the toggle is enabled, should the file include something like the following?

Adult Briefs (Large/X-Large) In-Kind Value Adult Briefs (Small/Medium) In-Kind Value ...

@cielf
Copy link
Collaborator Author

cielf commented Dec 29, 2024

I'm officially off at the moment, so I'm not going to dig . Please verify whatever I say here against the code. Wiithout digging, I suspect that in-kind value in the donation file is the sum of all the in-kind values across the items.

If that's the case, I'm torn between leaving it alone because someone might be using the title in their further processing, and renaming it for future clarity. Let's rename it, but please note in your PR that we will need to do communication to the users about that renaming.

@nozomirin
Copy link
Contributor

nozomirin commented Dec 31, 2024

I found two issues:

  1. The donation filters have not been implemented in the export function.
  2. What unit do the values use? Distribution uses dollars, but donations use cents.

@cielf
Copy link
Collaborator Author

cielf commented Dec 31, 2024

Let's use dollars. I'll put filtering into our queue as a separate issue.

@nozomirin
Copy link
Contributor

OK, I will make some changes.

@nozomirin
Copy link
Contributor

Is it necessary to put a dollar sign before the values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants