Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't populate Kit as an item from base items #4887

Open
2 tasks
cielf opened this issue Dec 22, 2024 · 4 comments · May be fixed by #4895
Open
2 tasks

Don't populate Kit as an item from base items #4887

cielf opened this issue Dec 22, 2024 · 4 comments · May be fixed by #4895
Labels
Difficulty—Beginner Help Wanted Groomed + open to all!

Comments

@cielf
Copy link
Collaborator

cielf commented Dec 22, 2024

Summary

Exclude Kit from the items populated as base items

Why

Kit is special - and kits have to be created using the kit process

Details

When you create a new organization, its items are created from the list of base items
Kit should be excluded.

Criteria for completion

  • behaviour as described
  • automated test to demonstrate
@cielf cielf added Difficulty—Beginner Help Wanted Groomed + open to all! labels Dec 22, 2024
@nozomirin
Copy link
Contributor

/assign

@nozomirin
Copy link
Contributor

nozomirin commented Dec 27, 2024 •
edited
Loading

I created an organization, and the Kits list was empty.
So, do you mean that the kit row should be removed from the base_items table?
@cielf

@cielf
Copy link
Collaborator Author

cielf commented Dec 28, 2024 •
edited
Loading

There is a base item called "Kit". When you create a new organization, items are populated from the base items. That should exclude "Kit".

There are reasons it has to be in the base items -- as items that represent Kits have that as their base item.

@nozomirin
Copy link
Contributor

OK, I got it.

nozomirin added a commit to nozomirin/human-essentials that referenced this issue Dec 29, 2024
@nozomirin
Fix the issue where the kit should be excluded when the organization …
f058d41 
…is created. (rubyforgood#4887)
@nozomirin nozomirin linked a pull request Dec 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty—Beginner Help Wanted Groomed + open to all!
Projects
None yet
Milestone
No milestone
2 participants
@cielf @nozomirin