-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type macros may follow a different naming convention #145
Comments
This seems like an amendment we'd want to make now. In the intervening years I think PascalCase has emerged as a standard for type macros (like |
This comment has been minimized.
This comment has been minimized.
@rfcbot fcp merge This proposes amending our naming conventions to recommend type macros use PascalCase naming instead of snake_case. |
Team member @KodrAus has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
Are there any type macros in the standard library already? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔔 This is now entering its final comment period, as per the review above. 🔔 psst @KodrAus, I wasn't able to add the |
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. The RFC will be merged soon. psst @KodrAus, I wasn't able to add the |
#135 (comment) suggests a nice one:
I did not consider type macros when adding a case convention for macros in C-CASE. I have also never used a type macro myself. Will need to survey the ecosystem and see whether
PascalCase!
for type macros would be a good recommendation.The text was updated successfully, but these errors were encountered: