Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed not working on various Vimeo URLs #14

Open
Toutouwai opened this issue Jul 10, 2018 · 2 comments
Open

Embed not working on various Vimeo URLs #14

Toutouwai opened this issue Jul 10, 2018 · 2 comments

Comments

@Toutouwai
Copy link

The video embed is not working on the following types of Vimeo URLs, where "123456789" is the ID of the video:

https://vimeo.com/channels/staffpicks/123456789
https://vimeo.com/ondemand/somevideoname/123456789 (should show the trailer for the on demand video)

Real examples:
https://vimeo.com/channels/staffpicks/275891086
https://vimeo.com/ondemand/dyslexia/83856163
@ryancramerdesign ryancramerdesign mentioned this issue May 14, 2021
Open
@madebymats
Copy link

I also encountered this on this video for example: https://vimeo.com/553329597/04c306a466

@Toutouwai
Copy link
Author

@netcarver has posted a version of the module that seems to solve this issue.
https://processwire.com/talk/topic/1536-module-video-embed-for-youtubevimeo-textformattervideoembed/?do=findComment&comment=241005

netcarver added a commit to pwgeeks/TextformatterVideoEmbed that referenced this issue May 6, 2024
@netcarver
fix: Allow more recent Vimeo url formats
31bac99 
This allows newer Vimeo formats where the ID is now a hex string,
not just decimals, and where there can be multiple URL segments
before the video id.

Fixes ryancramerdesign#14 on the [original repo](ryancramerdesign#14)

Fixes this issue from the [PW forum](https://processwire.com/talk/topic/1536-module-video-embed-for-youtubevimeo-textformattervideoembed/?do=findComment&comment=240999)
@netcarver netcarver mentioned this issue May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Allow more recent Vimeo url formats pwgeeks/TextformatterVideoEmbed
2 participants
@Toutouwai @madebymats