Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider renaming diag argument in psychsyn #30

Open
awmeade opened this issue Mar 28, 2021 · 1 comment
Open

consider renaming diag argument in psychsyn #30

awmeade opened this issue Mar 28, 2021 · 1 comment

Comments

@awmeade
Copy link
Collaborator

awmeade commented Mar 28, 2021

Great package! So nice it's on CRAN now!
I was expecting the diag argument to mean 'diagonal' but i can't tell that there are any diagonals involved. perhaps renaming to something more intuitive?
@ryentes
Copy link
Owner

ryentes commented Apr 25, 2021

Yeah in retrospect that's an ambiguous abbreviation. We were discussing several alternative names for that argument. for example: "n_pairs", "count_pairs", or simply "pairs". The output column name is currently numPairs but that may change too as we have moved away from camel case in our more recent code.

I definitely welcome comments and suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@awmeade @ryentes