Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users Datasource: adding a user always approves the user even if you pass "Approved=false" #236

Open
Timo-Breumelhof opened this issue May 15, 2024 · 0 comments
Open

Users Datasource: adding a user always approves the user even if you pass "Approved=false" #236

Timo-Breumelhof opened this issue May 15, 2024 · 0 comments
Assignees
@skamphuis
Labels
enhancement
Milestone
05.01.00

Comments

@Timo-Breumelhof
Copy link
Collaborator

See:

OpenContent/OpenContent/Components/Datasource/DnnUsersDataSource.cs

Line 252 in dca3dfd

user.Membership.Approved = true; //chkAuthorize.Checked;

It would be better IMO if this would use the passed Approved value when it's passed from the edit form.
Set Approved to True if not defined
@Timo-Breumelhof Timo-Breumelhof added this to the 05.01.00 milestone May 15, 2024
skamphuis added a commit that referenced this issue May 15, 2024
@skamphuis
#fixes #236
dde178e
skamphuis added a commit that referenced this issue May 15, 2024
@skamphuis
Merge pull request #237 from sachatrauwaen/feature/236-Users-Datasour…
b2707cd 
…ce-IsApproved

fixes #236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skamphuis skamphuis

Labels
enhancement
Projects
None yet
Milestone
05.01.00
Development

No branches or pull requests
2 participants
@skamphuis @Timo-Breumelhof