Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer builds for any architecture except x86 #18

Open
infinity0 opened this issue Mar 14, 2014 · 4 comments
Open

no longer builds for any architecture except x86 #18

infinity0 opened this issue Mar 14, 2014 · 4 comments

Comments

@infinity0
Copy link

Commit 8de2315 broke the build for all non-x86 architectures. The offending code is this:

#ifndef __SSE_MATH__
    __asm__ __volatile__ ( "emms");
#endif

Changing it to

#ifdef __MMX__
    __asm__ __volatile__ ( "emms");
#endif

(similar to how things are done in alg.c) restores the build for all platforms.

I have added this to pull request #16.

@tosiara
Copy link

tosiara commented Mar 14, 2014

There is already pull request for this: #7

@infinity0
Copy link
Author

My patch is shorter and consistent with the existing code in alg.c which uses __MMX__, and more "to the point". We want to check for MMX, not the lack of anything else, "not not MMX".

@tosiara
Copy link

tosiara commented Mar 24, 2014

My mentioned pull request has been commited int mainstream: ad7e243

Ken-M pushed a commit to Ken-M/motion that referenced this issue Aug 21, 2014
Whitespace fix for better merge with upstream
@infinity0
Copy link
Author

Added some more commits (42bacdc, 20fb831) to build for Debian GNU/kFreeBSD.

dfries added a commit to dfries/motion that referenced this issue Aug 23, 2015
0005-fix-build-for-non-x86-platforms-which-define-neither.patch
fix build for non-x86 platforms, which define neither __SSE_MATH__ nor
__MMX__

Author: Ximin Luo <[email protected]>
Bug: sackmotion#18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants