Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private declarations that should be public in LoRa.h #699

Open
NicHub opened this issue Aug 7, 2024 · 1 comment
Open

Private declarations that should be public in LoRa.h #699

NicHub opened this issue Aug 7, 2024 · 1 comment

Comments

@NicHub
Copy link

NicHub commented Aug 7, 2024

In LoRa.h, are you sure you want the declarations from lines¹ 97 to 115 to be private? I especially need readRegister to be public but the other declarations can also be useful for end users.

¹ Line numbers of version 0.8.0 on PlatformIO:
https://registry.platformio.org/libraries/sandeepmistry/LoRa/versions

@Kongduino
Copy link

Indeed. I move manually read/writeRegister to public...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants