Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scalac warnings #14

Open
yanns opened this issue Mar 2, 2021 · 0 comments
Open

scalac warnings #14

yanns opened this issue Mar 2, 2021 · 0 comments
Assignees
@xsoufiane

Comments

@yanns
Copy link
Contributor

yanns commented Mar 2, 2021 

[info] compiling 10 Scala sources to /Users/yannsimon/projects/sangria-graphql-org/sangria-federated/target/scala-2.13/classes ...
[warn] /Users/yannsimon/projects/sangria-graphql-org/sangria-federated/src/main/scala/sangria/federation/_Any.scala:21:15: abstract type Node in type pattern sangria.federation.NodeObject[Node] is unchecked since it is eliminated by erasure
[warn]       case n: NodeObject[Node] =>
[warn]               ^
[warn] /Users/yannsimon/projects/sangria-graphql-org/sangria-federated/src/main/scala/sangria/federation/Federation.scala:68:44: type Traversable in package scala is deprecated (since 2.13.0): Use Iterable instead of Traversable
[warn]       override def getMapKeys(node: Node): Traversable[String] = default.getMapKeys(node)
[warn]                                            ^
[warn] two warnings found

We should make scalac warnings fatal errors when CI is running.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xsoufiane xsoufiane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yanns @xsoufiane