Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example using @interfaceObject directive #283

Closed
oskargotte opened this issue Nov 13, 2023 · 8 comments
Closed

add example using @interfaceObject directive #283

oskargotte opened this issue Nov 13, 2023 · 8 comments

Comments

@oskargotte
Copy link
Contributor

I was looking into adding an example using the @interfaceObject directive from federation v2.3, similar to what's outlined in #222. Is this of any value or is it better to add that to the subgraph compatibility testing repository where there are examples of all federation directives?

@yanns
Copy link
Contributor

yanns commented Nov 13, 2023

the subgraph compatibility is maybe even better.
Another idea is #215

@oskargotte
Copy link
Contributor Author

Yes. Adding the compliance tool would be nice. But I'm not sure what's need in terms of subgraph support. Would it mean this repository would have a complete copy of the sangria folder? As a complement to the current example or as a replacement?

@yanns
Copy link
Contributor

yanns commented Nov 13, 2023

I'm sure I follow you.

@oskargotte
Copy link
Contributor Author

oskargotte commented Nov 13, 2023

I'm sure I follow you.

Yeah, this one seems fairly straight forward. I can open a draft PR in the compatibility repo for you to review. If you're ok with that?

But this one seems to be a bit more work. From what I understand it's not only adding the tool as a github action but it would also require this repository to implement the same kind of subgraph as the one in the subgraph compatibility testing repository.

@yanns
Copy link
Contributor

yanns commented Nov 13, 2023

I'm sure I follow you.

Yeah, this one seems fairly straight forward. I can open a draft PR in the compatibility repo for you to review. If you're ok with that?

of course! Thanks a lot!

But this one seems to be bit more work. From what I understand it's not only adding the tool as a github action but it would also require this repository to implement the same kind of subgraph as the one in the subgraph compatibility testing repository.

Yes you're right.

@oskargotte
Copy link
Contributor Author

Great! I'll try to target the first bullet then.

@oskargotte
Copy link
Contributor Author

Please have a look when you have time: apollographql/apollo-federation-subgraph-compatibility#554

@oskargotte
Copy link
Contributor Author

Closing this since there is now an example of @interfaceObject usage in apollographql/apollo-federation-subgraph-compatibility#555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants