Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect dependency loops in module migrator #249

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Detect dependency loops in module migrator #249

wants to merge 1 commit into from

Conversation

pamelalozano16
Copy link
Contributor

Fix #137.

@jathak jathak mentioned this pull request Dec 12, 2023
Merged
@nex3 nex3 requested a review from jathak December 13, 2023 01:56
jathak
jathak requested changes Dec 15, 2023
View reviewed changes
lib/src/migrators/module.dart Outdated Show resolved Hide resolved
lib/src/migrators/module.dart Outdated Show resolved Hide resolved
lib/src/migrators/module.dart Outdated Show resolved Hide resolved
lib/src/migrators/module.dart Outdated Show resolved Hide resolved
test/migrators/module/namespace_references/loop_error.hrx Show resolved Hide resolved
@pamelalozano16 pamelalozano16 force-pushed the fix#137 branch 5 times, most recently from 76e48bd to c594c32 Compare June 19, 2024 00:06
@pamelalozano16 pamelalozano16 requested a review from jathak June 19, 2024 00:22
@pamelalozano16 pamelalozano16 force-pushed the fix#137 branch 2 times, most recently from 342a229 to 8592cc3 Compare June 20, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathak jathak Awaiting requested review from jathak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module migrator can generate @use loops
2 participants
@pamelalozano16 @jathak