Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make extra field appending independent of replacement logic #37

Open
berntpopp opened this issue Jan 3, 2025 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@berntpopp
Copy link
Member

Currently, our logic for appending extra sample fields (DP, AD, etc.) is tightly coupled with genotype replacement. We want to decouple or modularize this so that extra fields can be appended even if genotype replacement is turned off (or vice versa).

Details & Acceptance Criteria

  • Separate the “append extra sample fields” steps into a self-contained function/module, ensuring it can be called independently from the main genotype replacement flow.
  • Preserve existing functionality (no regressions): if a user still wants genotype replacement + extra fields, it should remain seamless.
  • Document the new approach so users can enable/disable them individually.

Why This Is Valuable

  • Improves code maintainability by separating concerns.
  • Offers more configuration flexibility for users who only need one feature without the other.
@berntpopp berntpopp added the enhancement New feature or request label Jan 3, 2025
@berntpopp berntpopp self-assigned this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant