Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are cmake, ctest and cpack functions part of API? #28

Open
blowekamp opened this issue Jul 20, 2017 · 3 comments
Open

Are cmake, ctest and cpack functions part of API? #28

blowekamp opened this issue Jul 20, 2017 · 3 comments
Labels
Status: Awaiting response ⏳ Waiting for a response/more information Type: Enhancement Improvement to functionality Type: Question User question

Comments

@blowekamp
Copy link

These functions are not documented in the read the docs. Are the intended for public usage?

jcfr added a commit that referenced this issue Jul 26, 2017
@jcfr
Copy link
Contributor

jcfr commented Jul 26, 2017

They are currently used as entrypoint in setup.py. That way, a wrapper executable named after each function is automatically created after installing the wheel.

See

entry_points={
'console_scripts': [
'cmake=cmake:cmake', 'cpack=cmake:cpack', 'ctest=cmake:ctest'
]
},

To make them useful for public consumption, I think we would need something like this: https://github.com/scikit-build/cmake-python-distributions/compare/28-add-cmake-ctest-cpack-to-public-api

Let me know what you think.

Thanks
Jc

@blowekamp
Copy link
Author

I have a couple needs to invoke a CMake scripts from Python.

  1. Use CMake's ExternalData module in a Sphinx build on ReadTheDocs for downloading images. With CMake and Ninja being in PyPi, this should easily be done.
  2. Use a CMake script from setup.py to determine SimpleITK's source code version via the CMake scripts.

I will pursue this tasks as some point with my own wrapper to see what the requirements will be.

Thanks!

@jcfr
Copy link
Contributor

jcfr commented Jul 28, 2017

Makes sense.

When I have some cycle, I will look into finalizing https://github.com/scikit-build/cmake-python-distributions/compare/28-add-cmake-ctest-cpack-to-public-api that is general enough I think.

I will pursue this tasks as some point with my own wrapper to see what the requirements will be.

Great. Then, based on your findings we can definitively integrate them here.

Have a good weekend,
Jc

@jcfr jcfr added backlog Type: Enhancement Improvement to functionality help wanted and removed backlog labels Jul 28, 2017
@jcfr jcfr added Type: Question User question Status: Awaiting response ⏳ Waiting for a response/more information and removed help wanted labels May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting response ⏳ Waiting for a response/more information Type: Enhancement Improvement to functionality Type: Question User question
Projects
None yet
Development

No branches or pull requests

2 participants