You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 18, 2023. It is now read-only.
The renaming script assumes that the wheels built from master would have a commit hash in the version name:
e.g. 0.18.0.dev0+58dbafa where it would replace +58dbafa with the date.
but ours are just 0.18.0.dev0, so nothing gets replaced and no date is added.
I see a few possible ways to proceed:
1.) change scikit-image to add a hash to the version string
2.) modify the rename_wheel function to append the date without trying to replace an existing hash
3.) If we only intend to use this repo to build and upload tagged versions then no action is needed
@jni and @hmaarrfk : Do either of you have a preference?
Option 2 will be simpler if we don't care to have the version hash reported in skimage.version. Adding the version hash handling in SciPy does complicate their setup.py a bit
The text was updated successfully, but these errors were encountered:
I would postpone this action until we start using versioneer or setuptools_scm. (I have a slight preference towards versioneer to avoid an extra dependency.) But I don't have strong feelings about this.
To clarify this stance: I would strongly prefer not to complicate our setup.py, but rather to outsource this logic to versioneer or setuptools_scm. And actually, despite what I said above, maybe setuptools_scm is a better choice since it seems to be more actively maintained.
moving discussion here from #45
The renaming script assumes that the wheels built from master would have a commit hash in the version name:
e.g. 0.18.0.dev0+58dbafa where it would replace +58dbafa with the date.
but ours are just 0.18.0.dev0, so nothing gets replaced and no date is added.
I see a few possible ways to proceed:
1.) change scikit-image to add a hash to the version string
2.) modify the rename_wheel function to append the date without trying to replace an existing hash
3.) If we only intend to use this repo to build and upload tagged versions then no action is needed
@jni and @hmaarrfk : Do either of you have a preference?
Option 2 will be simpler if we don't care to have the version hash reported in skimage.version. Adding the version hash handling in SciPy does complicate their setup.py a bit
The text was updated successfully, but these errors were encountered: