Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Afterburner loop sound doesn't fade out after releasing it's hotkey #6504

Open
JacobPease opened this issue Jan 3, 2025 · 1 comment
Open

Afterburner loop sound doesn't fade out after releasing it's hotkey #6504

JacobPease opened this issue Jan 3, 2025 · 1 comment
Assignees
@Goober5000
Labels
bug An issue from unintended consequences sound A feature or issue specific to music and sound

Comments

@JacobPease
Copy link

Like the title says, the afterburner loop sound doesn't fade out after releasing the hotkey. After releasing the hotkey it stays around long enough for the sound to fade out, but it doesn't. It just abruptly ends.

You can hear this in this video I recorded within the first few moments.

Shield Effect Test with Afterburner Loop Sound bug
@Gamma39er
Copy link

Oh, hi me.

@Goober5000 Goober5000 added bug An issue from unintended consequences sound A feature or issue specific to music and sound labels Jan 10, 2025
@Goober5000 Goober5000 self-assigned this Jan 10, 2025
@github-project-automation github-project-automation bot moved this to Needs triage in Bug Triage Jan 10, 2025
Goober5000 added a commit to Goober5000/fs2open.github.com that referenced this issue Jan 10, 2025
@Goober5000
fix volume updates for looping sounds
38f00ff 
Now that `snd_do_frame()` has been tightened up to specifically only adjust audio for the adjust-audio-volume sexp, the redundancy-avoiding code in `snd_set_volume()` is obsolete.  So, set the sound volume immediately, even if it is a looping sound.

This is a two-for-one fix; the proper setting of volume fixes both scp-fs2open#6504 and scp-fs2open#6507.
@Goober5000 Goober5000 mentioned this issue Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Goober5000 Goober5000

Labels
bug An issue from unintended consequences sound A feature or issue specific to music and sound
Projects
Bug Triage
Status: Needs triage
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Goober5000 @JacobPease @Gamma39er