Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Night Owl theme is either overriding or not specifying default markup textMateRules #57 #105 #283

Closed
smcenlly opened this issue Jan 28, 2021 · 2 comments

Comments

@smcenlly
Copy link

smcenlly commented Jan 28, 2021

Describe the bug
Theme is either overriding or not specifying default markup textMateRules that are provided with VS Code default themes. This breaks syntax highlighting in extensions that use these rules.

To Reproduce
Steps to reproduce the behavior:

  1. Clone https://github.com/smcenlly/missing-textmate-tokens VS Code sample extension.
  2. Open the repo and run npm install
  3. Open the repo in VS Code and Start debugging (F5).
  4. Create a new file (Ctrl + N).
  5. Change its language to markup using the Change Language Mode command
  6. Paste the contents below:
deleted

inserted

underline
  1. Using any of the VS Code themes, you will see output similar to:
    Working Example

Expected behavior
Theme should provide similar formatting (adjusted to its themes). Instead, no highlighting is displayed.

image

@smcenlly
Copy link
Author

Bumping this issue - any plans to fix?

sdras added a commit that referenced this issue Dec 28, 2024
@sdras
Copy link
Owner

sdras commented Dec 28, 2024

Added this in, thank you for the example repo. There's no way to check the language in settings anymore. Cutting a release today.

@sdras sdras closed this as completed Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants