Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manufacturers array should only select one manufacturer per item, shouldn't match on easy criteria #539

Open
seveibar opened this issue Oct 25, 2023 · 1 comment
Labels
SupportedDevicesTable Affects the SupportedDevicesTable component.

Comments

@seveibar
Copy link
Contributor

Related to same search in #538

If I search for "A" it shouldn't match both "August" and "Schlage" because they both contain an "A", there should be some notion of edit distance or some kind of better matching criteria.

@razor-x
Copy link
Collaborator

razor-x commented Oct 25, 2023

@codetheweb Could use some help on this one. It must be with how https://github.com/gajus/liqe is used. Not sure if the fix has to happen here (https://github.com/seamapi/react/blob/main/src/lib/seam/components/SupportedDeviceTable/use-filtered-manufacturers.ts#L15) or on the backend.

@razor-x razor-x added the SupportedDevicesTable Affects the SupportedDevicesTable component. label Oct 25, 2023
@razor-x razor-x changed the title manufacturers array should only select one manufacturer per item, shouldn't match on easy critera manufacturers array should only select one manufacturer per item, shouldn't match on easy criteria Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SupportedDevicesTable Affects the SupportedDevicesTable component.
Projects
None yet
Development

No branches or pull requests

2 participants