You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the comment of the formatTime method of the Client class it is argued that it is possible to use the result of microtime(true), which is a float. But in the only place where the method is used, in the message method of the same class, the value is cast to integer, making it effectively impossible to pass a timestamp with the precision of milli / micro seconds.
For reference, I saw that the cast was added in this refactoring.
I am going to open a PR to remove the cast to integer.
The text was updated successfully, but these errors were encountered:
In the comment of the
formatTime
method of theClient
class it is argued that it is possible to use the result ofmicrotime(true)
, which is a float. But in the only place where the method is used, in themessage
method of the same class, the value is cast to integer, making it effectively impossible to pass a timestamp with the precision of milli / micro seconds.For reference, I saw that the cast was added in this refactoring.
I am going to open a PR to remove the cast to integer.
The text was updated successfully, but these errors were encountered: