Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samsung phones shown as tablets (SGH-I527 & SPH-L600 #74

Open
drlatech opened this issue Feb 14, 2017 · 3 comments
Open

Samsung phones shown as tablets (SGH-I527 & SPH-L600 #74

drlatech opened this issue Feb 14, 2017 · 3 comments

Comments

@drlatech
Copy link

There are also 2 more models which are shown as tablets.

Samsung-SGH-I527, with this user agent
Mozilla/5.0 (Linux; U; Android 4.2.2; en-us; SAMSUNG-SGH-I527 Build/JDQ39) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Safari/534.30 FB_IAB/FB4A;FBAV/104.0.0.17.71;

Samsung-SPH-L600
Mozilla/5.0 (Linux; U; Android 4.2.2; en-us; SPH-L600 Build/JDQ39) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Safari/534.30 FB_IAB/FB4A;FBAV/85.0.0.15.70;

I debugged function parse in parsers, the problem is that there is no 'Mobile' in user agent, before Safari, so this automatically becomes tablet. I thought that this could be related with screen size and resolution. They are 6.3 inches.

I've noticed that there are more Samsung models in issues, so I would like to know if there is an interest to solve these issues with them. Thanks

@drlatech drlatech changed the title Samsung phones shown as tables (SGH-I527 & SPH-L600 Samsung phones shown as tablets (SGH-I527 & SPH-L600 Feb 23, 2017
@emmettbutler
Copy link
Contributor

Duplicate of #73?

@drlatech
Copy link
Author

Yes, it is. I made this because no reactions on #73 ...

@art-fotinich
Copy link

art-fotinich commented Aug 10, 2017

Observing the same problem for most of Android devices. Vast majority classified as Tablets, while they are clearly Mobile Phones. Otherwise seem to be a good parser. Wish I had time to fix the issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@emmettbutler @drlatech @art-fotinich and others