Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove source from default Display implementation #356

Closed
shepmaster opened this issue Sep 27, 2022 · 0 comments
Closed

Remove source from default Display implementation #356

shepmaster opened this issue Sep 27, 2022 · 0 comments
Labels
breaking change Likely requires a SemVer version bump

Comments

@shepmaster
Copy link
Owner

An error type with a source error should either return that error via source or include that source's error message in its own Display output, but never both.

rust-lang/project-error-handling#27 (comment)

So we should remove that as we do use source. Make sure to update the guide sections where we talk about the default display implementation.
@shepmaster shepmaster added the breaking change Likely requires a SemVer version bump label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Likely requires a SemVer version bump
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shepmaster