add more flags #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham1172
reviewed
Aug 23, 2022
Comment on lines
+53
to
+54
| PyModule_AddIntConstant(module, "CLONE_THREAD", CLONE_SIGHAND); // signal handlers and blocked signals | ||
| PyModule_AddIntConstant(module, "CLONE_THREAD", CLONE_VM); // virtual memory |
|
What does build command report?
#IFDEF is a compile time flag, it won't prevent usage of the flags in the python package, right? We can leave it as is too IMO, the error code should tell if the used flag was unsupported. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't get this repo to build at all on my system... but this should be close
some of these flags will require a newer kernel... should we #ifdef them?