Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sizes not in html #38

Open
Maarten7 opened this issue Feb 14, 2020 · 2 comments · May be fixed by #80
Open

sizes not in html #38

Maarten7 opened this issue Feb 14, 2020 · 2 comments · May be fixed by #80

Comments

@Maarten7
Copy link

Hello all,
The links to the icons generated my django-pwa do not show the sizes attribute as set in the settings.
It leaves it empty.
This error comes up while validating html-code:

Error: Bad value "" for attribute sizes on element link

Great "app" by the way thanks for making it.
@VivienGiraud
Copy link
Contributor

Same here, did you find a way to handle it?

@PetrDlouhy
Copy link

The problem is in the tutorial. The property in code is named size, not sizes.

PetrDlouhy added a commit to PetrDlouhy/django-pwa that referenced this issue Nov 11, 2021
@PetrDlouhy
Fix sizes property name to size in README
aa45bf2 
Fix silviolleite#38 
The `sizes` property name in README doesn't match with the code, where is it named `size`: https://github.com/silviolleite/django-pwa/blob/0ff60e7afaf23d6883d593554b93e54bb56e41fe/pwa/templates/pwa.html#L19
@PetrDlouhy PetrDlouhy linked a pull request Nov 11, 2021 that will close this issue
Open
Dhinagaran-s added a commit to Dhinagaran-s/django-pwa-custom that referenced this issue Aug 21, 2022
@Dhinagaran-s
solved issues silviolleite#37 silviolleite#38 silviolleite#59 silviol…
03a0da6 
…leite#70 from django-pwa
@Dhinagaran-s Dhinagaran-s mentioned this issue Aug 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sizes property name to size in README PetrDlouhy/django-pwa
3 participants
@PetrDlouhy @VivienGiraud @Maarten7