Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: Theme handling suggestion #2259

Open
Sp3EdeR opened this issue Dec 3, 2024 · 1 comment
Open

New feature: Theme handling suggestion #2259

Sp3EdeR opened this issue Dec 3, 2024 · 1 comment

Comments

@Sp3EdeR
Copy link

Sp3EdeR commented Dec 3, 2024

Hello devs,

Caprine currently supports custom themes, however current use-cases require one to copy-paste the theme CSS into the local file fully. When Facebook updates Messenger's code, it is possible that some themes may break. For example the Discord theming community already works around this issue by pushing themes to Github pages, and importing them into the client using the following CSS syntax:

@import url("https://sp3eder.github.io/black-messenger-for-caprine/theme.css");

I tried to use the above in Caprine, however it appears not to work using the current CSS injection mode. According to the debugger, no request is sent for this file by the client. I think it would be a useful feature to add support for this syntax, to support a more stable theming system.

@mquevill
Copy link
Collaborator

When Facebook updates Messenger's code, it is possible that some themes may break.

^ Not only themes, but some of Caprine's core functionality breaks when there's back-end changes to Messenger...

I haven't had much luck into figuring out why this is not possible with webContents.insertCSS() function that Caprine uses to add the CSS, but could be worth looking into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants