Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin version in Dockerfiles #11

Open
dougbtv opened this issue May 2, 2016 · 4 comments
Open

Pin version in Dockerfiles #11

dougbtv opened this issue May 2, 2016 · 4 comments

Comments

@dougbtv
Copy link
Member

dougbtv commented May 2, 2016

I'm building a commit right now that pins the homer-api & homer-ui verisons by commit hash. This one: sipcapture/homer-docker@e8fa985

On my wishlist is tags with semver or something (which I see has been done at least during major releases, very nice) on those projects. It will look nicer in the dockerfile when I can pin it at specific tags, e.g. we can clone a tag like...

git clone --branch vX.Y.Z https://github.com/sipcapture/homer-ui.git

Because we've had homer-ui & homer-api running @ HEAD I'm running into a bit of "Schrödinger's Docker images" where I don't know if the Dockerfile is going to be working or not until I build it. In this case today, because of some changes to the new rotation scripts, I'm seeing it happen again.

For now, I'm just going to git checkout [sha-1] in the Dockerfile, and I'll merge what I've got for now (assuming the build is verified). But, this will allow us to be sure that it will work when HEAD is changing on the primary projects. And, when the time's right, to go ahead and test it out with newer commits.

@lmangani
Copy link
Member

lmangani commented May 2, 2016

Hey Doug!

Excellent point! A solution to this is actually be possible by pulling the sipcapture/homer repository which contains the sumodules pointers - those are currently updated when we fix something, but with a little bit of method, we could leverage the main repository (and branches) to control what we serve to the stable front (containers, installers, etc) and leave direct pull from ui/api repos for the developers - Just a proposal for the bunch to comment on.

@dougbtv
Copy link
Member Author

dougbtv commented May 2, 2016

Ahhhh ha! You've got submodules in there. That..... that is actually quite awesome. And maybe something that I can start making use of sooner than later.

Absolutely curious to hear what everyone likes, I'd just like to leverage what you guys have in place, and what makes sense for everyone.

@mbrooks
Copy link
Contributor

mbrooks commented Feb 8, 2017

This maybe the wrong place to request this, but tagging the release version for the entire project would be nice. We're currently having to use the git commit hash as well. I can submit a PR if you guys are interesting in versioning this.

@sfrique
Copy link

sfrique commented Jan 7, 2018

Also it would be nice to build the images and pull it to somewhere (docker hub?).
So new users don't have to build the image, only use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants