-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coding mutations in non-coding variants table #231
Comments
Hi @sci-kai! Thanks for reaching out. Variants for which a HGVSp value has been annotated are considered as coding variants. I assume that your variant does not have one? I am not sure if this is the one criteria but I will have a look at this after the weekend and come back to you. Edit: I just checked and splitting variants in coding and non-coding variants is done by considering canonical transcripts and the presence/absence of a HGVSp value in each variant. |
Thanks for the clarification! Also good to know that the transcript selection process is also performed at this step. |
I think we should rename the tables slightly, such that it becomes clear that noncoding can also contain variants where no information on the amino acid impact is available. |
suggestions welcome |
Hi Johannes, I think it is a good idea to add "unknown" or something similar to "noncoding", i.e., rename the "noncoding" table into "noncoding/unknown". |
We also currently investigate the possibility to merge all into one, because it is cumbersome to open a separate view just to see the noncoding/unknown variants. |
Hi, I have an issue with the table splitting in coding and non-coding variants.
Within my dataset there are (germline) variants annotated in their consequence with "frameshift_variation" or even "coding_sequence_variant" that are sorted within the "non-coding" table.
I may not understand the criteria which define coding and non-coding variants, it would be nice to have more documentation and clarity about these to understand this error.
Here is an example variant that I found in the non-coding table:
The text was updated successfully, but these errors were encountered: