Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off serving AS2 actors (at least non-web) via /r/ URLs #1654

Open
saschanaz opened this issue Dec 26, 2024 · 8 comments
Open

Turn off serving AS2 actors (at least non-web) via /r/ URLs #1654

saschanaz opened this issue Dec 26, 2024 · 8 comments
Labels
bug User-facing breakage and reliability issues within Bridgy Fed.

Comments

@saschanaz
Copy link

> curl -H "Accept: application/activity+json" https://bsky.brid.gy/r/https://bsky.app/profile/sanhwa-lee.com
{
  "@context": [
    "https://www.w3.org/ns/activitystreams",
    {
      "discoverable": "http://joinmastodon.org/ns#discoverable",
      "indexable": "http://joinmastodon.org/ns#indexable"
    },
    {
      "PropertyValue": "schema:PropertyValue",
      "schema": "http://schema.org#"
    }
  ],
  "attachment": [
    {
      "name": "Link",
      "type": "PropertyValue",
      "value": "<a rel=\"me\" href=\"https://bsky.app/profile/sanhwa-lee.com\"><span class=\"invisible\">https://</span>bsky.app/profile/sanhwa-lee.com</a>"
    },
    {
      "name": "Link",
      "type": "PropertyValue",
      "value": "<a rel=\"me\" href=\"https://sanhwa-lee.com\"><span class=\"invisible\">https://</span>sanhwa-lee.com</a>"
    },
    {
      "name": "Link",
      "type": "PropertyValue",
      "value": "<a rel=\"me\" href=\"https://www.sanhwa-lee.com\"><span class=\"invisible\">https://</span>www.sanhwa-lee.com</a>"
    },
    {
      "type": "Image",
      "url": "https://enoki.us-east.host.bsky.network/xrpc/com.atproto.sync.getBlob?did=did:plc:xmbyi47sypz7q2mx5j7ay6sl&cid=bafkreihkh223dfofi7o2zg2zpy3xbdu4rjbxs5um3icld7gkkv5sfd3l54"
    },
    {
      "type": "Image",
      "url": "https://enoki.us-east.host.bsky.network/xrpc/com.atproto.sync.getBlob?did=did:plc:xmbyi47sypz7q2mx5j7ay6sl&cid=bafkreibrylyiodeo22ddgudi2ynbbnc5tbr5fejsce3wono36sda5s272m"
    }
  ],
  "discoverable": true,
  "icon": {
    "type": "Image",
    "url": "https://enoki.us-east.host.bsky.network/xrpc/com.atproto.sync.getBlob?did=did:plc:xmbyi47sypz7q2mx5j7ay6sl&cid=bafkreibrylyiodeo22ddgudi2ynbbnc5tbr5fejsce3wono36sda5s272m"
  },
  "id": "https://bsky.brid.gy/r/https://bsky.app/profile/sanhwa-lee.com",
  "image": [
    {
      "type": "Image",
      "url": "https://enoki.us-east.host.bsky.network/xrpc/com.atproto.sync.getBlob?did=did:plc:xmbyi47sypz7q2mx5j7ay6sl&cid=bafkreihkh223dfofi7o2zg2zpy3xbdu4rjbxs5um3icld7gkkv5sfd3l54"
    },
    {
      "type": "Image",
      "url": "https://enoki.us-east.host.bsky.network/xrpc/com.atproto.sync.getBlob?did=did:plc:xmbyi47sypz7q2mx5j7ay6sl&cid=bafkreibrylyiodeo22ddgudi2ynbbnc5tbr5fejsce3wono36sda5s272m"
    }
  ],
  "indexable": true,
  "name": "\uc774\uc0b0\ud654",
  "preferredUsername": "sanhwa-lee.com",
  "summary": "Science Fiction Writer. Strange Story Enthusiast.\n<a href=\"https://www.sanhwa-lee.com\">sanhwa-lee.com</a>",
  "to": [
    "https://www.w3.org/ns/activitystreams#Public"
  ],
  "type": "Person",
  "url": [
    "https://bsky.brid.gy/r/https://bsky.app/profile/sanhwa-lee.com",
    "https://bsky.brid.gy/r/https://sanhwa-lee.com/",
    "https://bsky.brid.gy/r/https://www.sanhwa-lee.com/"
  ]
}

Unclear why. Together with #1653, this means there's no mean to get inbox URL.

@saschanaz
Copy link
Author

saschanaz commented Dec 26, 2024

Interestingly, fetching https://bsky.brid.gy/r/https://bsky.app/profile/did:plc:xmbyi47sypz7q2mx5j7ay6sl also gives handle-based ID in this case, also without the inbox property.

@snarfed
Copy link
Owner

snarfed commented Dec 26, 2024

Oh wow, interesting. Yeah, we probably shouldn't be serving AS2 actors for paths like these at all.

Out of curiosity, do you know where this fetch came from? Ie, do you know where https://bsky.brid.gy/r/https://bsky.app/profile/sanhwa-lee.com or https://bsky.brid.gy/r/https://bsky.app/profile/did:plc:xmbyi47sypz7q2mx5j7ay6sl originally appeared as ActivityPub-fetchable ids?

@saschanaz
Copy link
Author

saschanaz commented Dec 26, 2024

It didn't appear really, I wanted to follow this user (saw in bsky) and that didn't work so I started debugging 😄

@snarfed
Copy link
Owner

snarfed commented Dec 26, 2024

Ah ok, thanks for the explanation. That user hasn't enabled the bridge, so you can't follow them from the fediverse yet. Congrats on finding an unusual way to convert part of their profile to AS2 though! Similar to https://granary.io/ , I guess.

I'll keep this issue open to track turning that off.

@saschanaz
Copy link
Author

I see ap.brid.gy in the followers list though 👀

@snarfed
Copy link
Owner

snarfed commented Dec 26, 2024

OK! They're not actually bridged though: https://fed.brid.gy/bsky/did:plc:xmbyi47sypz7q2mx5j7ay6sl . Maybe they followed ap.brid.gy before their profile was fully set up and satisfied https://fed.brid.gy/docs#troubleshooting, or maybe during an outage like #1520. Feel free to ask them to try again!

@snarfed snarfed changed the title Fetching through bsky.brid.gy/r/ doesn't give did-based ID for some users Turn off serving AS2 actors (at least non-web) via /r/ URLs Dec 26, 2024
@snarfed snarfed added the now label Dec 26, 2024
@saschanaz
Copy link
Author

Oh no, so I won't be able to (ab)use the /r/ url to resolve bsky URLs? I find it useful 😢

@snarfed
Copy link
Owner

snarfed commented Dec 26, 2024

Hah, sorry. It'll still work for Bluesky post URLs, if they're bridged! And you can find a bridged Bluesky user by their Webfinger, @[handle]@bsky.brid.gy (https://fed.brid.gy/docs#fediverse-follow-bluesky) or by their AP actor id, https://bsky.brid.gy/ap/[DID].

@Tamschi Tamschi added the bug User-facing breakage and reliability issues within Bridgy Fed. label Dec 29, 2024
@snarfed snarfed removed the now label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug User-facing breakage and reliability issues within Bridgy Fed.
Projects
None yet
Development

No branches or pull requests

3 participants