Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some repo-review things #400

Open
2 of 8 tasks
blakeNaccarato opened this issue May 4, 2024 · 0 comments
Open
2 of 8 tasks

Fix some repo-review things #400

blakeNaccarato opened this issue May 4, 2024 · 0 comments
Labels
enhancement New feature or request internal Internal

Comments

@blakeNaccarato
Copy link
Member

blakeNaccarato commented May 4, 2024

Please use this form appropriately

  • I am a maintainer or I have been directed me to use this form.

Please check that this internal matter hasn't already been raised

  • I searched here or here and couldn't find a similar issue.

Description

Repo review has a few false negatives, but some notable things are:

  • Change ruff hook to the new repo
  • Pytest things
  • Codespell (not a traditional spellchecker, probably a good addition)
  • Reconsider nox as a VSCode-agnostic task runner, then just hook into it with VSCode tasks (maybe a simple input selection list?)
  • Enforce Prettier even though we do use it locally
  • Raise discussions about other "violations" like Dependabot when we do use Renovate, pyright used instead of mypy, etc. See if there's a way to suppress codes with a rationale message given

https://scientific-python.github.io/repo-review/?repo=blakeNaccarato%2Fboilercv&branch=main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal Internal
Projects
Development

No branches or pull requests

1 participant