Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.83 causing warnings in "maturin develop" #1061

Open
dave42w opened this issue Nov 29, 2024 · 1 comment
Open

Rust 1.83 causing warnings in "maturin develop" #1061

dave42w opened this issue Nov 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@dave42w
Copy link
Contributor

dave42w commented Nov 29, 2024

Bug Description

I just updated to Rust 1.83.0 now my build is getting lots of these warnings

warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item
  --> src/server.rs:62:1
   |
62 | #[pymethods]
   | -^^^^^^^^^^^
   | |
   | `PyClassImplCollector` is not local
   | `PyClassNewTextSignature` is not local
   | move the `impl` block outside of this function `trampoline` and up 4 bodies
63 | impl Server {
   |      ------
   |      |
   |      `Server` is not local
   |      `Server` is not local
   |
   = note: the attribute macro `pymethods` defines the non-local `impl`, and may need to be changed
   = note: the attribute macro `pymethods` may come from an old version of the `pyo3_macros` crate, try updating your dependency with `cargo update -p pyo3_macros`
   = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl`
   = note: `#[warn(non_local_definitions)]` on by default
   = note: this warning originates in the attribute macro `pymethods` (in Nightly builds, run with -Z macro-backtrace for more info)

Steps to Reproduce

  1. Upgrade to Rust 1.83
  2. maturin develop

Your operating system

Linux

Your Python version (python --version)

3.12

Your Robyn version

main branch

Additional Info

No response

@dave42w dave42w added the bug Something isn't working label Nov 29, 2024
@sansyrox
Copy link
Member

We need to update pyo3 , i.e. support python3.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants