#601 add unread num chatting #692
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taxi-dev-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
14KGun
reviewed
Jan 2, 2024
| @@ -20,6 +20,7 @@ declare global { | |||
| | `${PixelValue} ${PixelValue} ${PixelValue} ${PixelValue}`; | |||
| type Padding = Margin; | |||
| type User = { | |||
| readAt: any; | |||
There was a problem hiding this comment.
type을 any 보다는 구체적으로 명시하는 것이 좋을 것 같습니다 !
Suggested change
| readAt: any; | |
| readAt?: Date; |
| @@ -44,6 +44,17 @@ export default ( | |||
| chatBodyRef.current.scrollTop = scrollTop; | |||
| }, [chats]); | |||
|
|
|||
| const lastChat = chats.length > 0 ? chats[chats.length - 1] : {}; | |||
There was a problem hiding this comment.
Suggested change
| const lastChat = chats.length > 0 ? chats[chats.length - 1] : {}; | |
| const lastChat = chats.at(-1); |
로 더 간단히 할 수 있을 것 같아요.
| data: { roomId }, | ||
| }) | ||
| ); | ||
| }, ["time" in lastChat ? lastChat?.time : ""]); |
There was a problem hiding this comment.
Suggested change
| }, ["time" in lastChat ? lastChat?.time : ""]); | |
| }, [lastChat?.time, roodId]); |
과 차이가 없을 것 같습니다 ! 그리고 roodId 도 추가되어야 할 것 같아요.
Comment on lines
+62
to
+65
| const readAts = useMemo(() => { | ||
| const readAts = roomInfo?.part?.map((user) => user?.readAt); | ||
| return readAts; | ||
| }, [chats, roomInfo]); |
There was a problem hiding this comment.
연산에서 chats가 사용되지 않아 dependency array 에서 제외되어도 될 것 같아요.
Suggested change
| const readAts = useMemo(() => { | |
| const readAts = roomInfo?.part?.map((user) => user?.readAt); | |
| return readAts; | |
| }, [chats, roomInfo]); | |
| const readAts = useMemo( | |
| () => roomInfo?.part?.map((user) => user?.readAt) || [], | |
| [roomInfo] | |
| ); |
Comment on lines
+185
to
+187
| {readAts?.filter((readAt) => readAt < chat.time).length == 0 | ||
| ? null | ||
| : readAts?.filter((readAt) => readAt < chat.time).length} |
There was a problem hiding this comment.
같은 연산이 두 번 반복되는데, 한 번의 계산으로 줄일 수 있을 것 같습니다 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #601
Images or Screenshots
Further Work