Pull Request #95 made the library require PHP ^8.0 #96
Closed
morloderex
started this conversation in
General
Replies: 1 comment
-
The pull request you mention only causes type |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hey everybody.
Recently #95 was merged. But the mixed type in PHP is a 8.0 only feature and the pr is therefore a breaking change that should have been thought of before getting merged.
So what course of action should be taken? Should the pr be reverted in order to maintain PHP 7.4 support. As I know @spawnia have stated here that he planned to support PHP 7.4 for a long time.
My suggestion would be to just remove PHP 7.4 support completely in a new major release probably 1.0 or something and call this library somewhat stable after doing this?
Thoughts?
Beta Was this translation helpful? Give feedback.
All reactions