Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors compiling 'src/.../skip_list.h','tests/.../minimum_swaps.cc', 'tests/.../image.cc' and 'src/.../rmq_sparse_table.h' #97

Closed
sheldonrobinson opened this issue Dec 26, 2024 · 4 comments · Fixed by #98

Comments

@sheldonrobinson
Copy link
Contributor

  1. Compile errors caused by missing #include <numeric> needed for iota in tests/algorithms/sorting/minimum_swaps.cc, and tests/machine_learning/image/image.cc
  2. Compile error caused by missing #include <string> in src/classes/list/skip_list.h
  3. Compile error cause by __builtin_clz not defined in for MSVC
Copy link

Thank you for your interest in AlgoPlus, a maintainer will see your issue soon!

@sheldonrobinson sheldonrobinson mentioned this issue Dec 26, 2024
@spirosmaggioros
Copy link
Owner

Hi @sheldonrobinson, thanks for taking the time to look at the project!
What OS do you have? I'm asking because i believe we are fine on MacOS and Linux(basically Unix based systems). If you have windows it will help us a lot, because the issues appear only there.

@spirosmaggioros spirosmaggioros linked a pull request Dec 26, 2024 that will close this issue
@sheldonrobinson
Copy link
Contributor Author

I am using the following compilers

  1. MSVC
    • version 14.42.17.12
    • Windows 11 SDK 10.0.26100.0
    • architecture arm64, x64
  2. Android
    • SDK android-35
    • ndk version 27.2.12479018
    • architecture arm64-v8a

@spirosmaggioros
Copy link
Owner

spirosmaggioros commented Dec 26, 2024

Yeah, never worked with MSVC. Thank you for testing it with this. Will merge your PR now, tests pass!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants