Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for Origin Trials #21

Open
spite opened this issue Nov 10, 2016 · 1 comment · May be fixed by #26
Open

Workaround for Origin Trials #21

spite opened this issue Nov 10, 2016 · 1 comment · May be fixed by #26
Labels
help wanted

Comments

@spite
Copy link
Owner

spite commented Nov 10, 2016

webvr.info recently implemented Origin Trials, so the WebVR API is available for the page.

One side-effect of that is that, since the API is "loaded" when the page loads and the OriginTrials token is processed, it overwrites with native methods what the emulator has injected from the content-script, creating a mess of native and injected methods.
@spite
Copy link
Owner Author

spite commented Nov 10, 2016

I have a feeling this can be solved with #10

Rewriting as a wrapper that can work with the existing implementation plus one (or more) emulated devices, should work.

Also it means that it has to implement the wrapping lazily, to support this new possibility open by using OriginTrials.

@wibblymat wibblymat linked a pull request Feb 16, 2017 that will close this issue
Open
@benfoxall benfoxall mentioned this issue Feb 18, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the polyfill wait until after the Origin Trial as kicked in wibblymat/WebVR-Extension
1 participant
@spite