Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for asynchronous retrieval from RedisCache #2650

Closed
christophstrobl opened this issue Jul 25, 2023 · 0 comments
Closed

Add support for asynchronous retrieval from RedisCache #2650

christophstrobl opened this issue Jul 25, 2023 · 0 comments
Assignees
@jxblum
Labels
type: enhancement A general enhancement
Milestone
3.2 RC1 (2023.1.0)

Comments

@christophstrobl
Copy link
Member

See: spring-projects/spring-framework#17920
Related issue: #1541
@christophstrobl christophstrobl added the type: enhancement A general enhancement label Jul 25, 2023
@mp911de mp911de changed the title Add reactive types support to RedisCacheManager. Add reactive types support to RedisCacheManager Aug 9, 2023
@mp911de mp911de changed the title Add reactive types support to RedisCacheManager Add reactive types support to RedisCacheManager Aug 9, 2023
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Aug 15, 2023
@jxblum
Implement retrieve(key) and retrieve(key, :Supplier<CompletableFuture…
80c88a5 
…<T>>) operations in Cache.

Closes spring-projects#2650
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Sep 21, 2023
@jxblum
Implement retrieve(key) and retrieve(key, :Supplier<CompletableFuture…
c7fb2fb 
…<T>>) operations in RedisCache.

Closes spring-projects#2650
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Sep 21, 2023
@jxblum
Implement retrieve(key) and retrieve(key, :Supplier<CompletableFuture…
62a43e0 
…<T>>) operations in RedisCache.

Closes spring-projects#2650
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Sep 21, 2023
@jxblum
Implement retrieve(key) and retrieve(key, :Supplier<CompletableFuture…
3c1dac4 
…<T>>) operations in RedisCache.

Closes spring-projects#2650
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Sep 22, 2023
@jxblum
Implement retrieve(key) and retrieve(key, :Supplier<CompletableFuture…
2807b81 
…<T>>) operations in RedisCache.

Closes spring-projects#2650
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Sep 23, 2023
@jxblum
Implement retrieve(key) and retrieve(key, :Supplier<CompletableFuture…
d87815f 
…<T>>) operations in RedisCache.

Closes spring-projects#2650
@jxblum jxblum changed the title Add reactive types support to RedisCacheManager Add reactive types support to RedisCache Sep 23, 2023
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Sep 25, 2023
@jxblum
Fix blocking bug in RedisCache.retrieve(..) when waiting on the cache…
c1e0745 
… lock.

Closes spring-projects#2650
@jxblum jxblum mentioned this issue Sep 26, 2023
Closed
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Sep 28, 2023
@jxblum
Implement retrieve(key) and retrieve(key, :Supplier<CompletableFuture…
4cfc229 
…<T>>) operations in RedisCache.

Closes spring-projects#2650
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Oct 3, 2023
@jxblum
Implement retrieve(key) and retrieve(key, :Supplier<CompletableFuture…
4f2a1ee 
…<T>>) operations in RedisCache.

Closes spring-projects#2650
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Oct 3, 2023
@jxblum
Implement retrieve(key) and retrieve(key, :Supplier<CompletableFuture…
0ddd674 
…<T>>) operations in RedisCache.

Closes spring-projects#2650
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Oct 3, 2023
@jxblum
Implement retrieve(key) and retrieve(key, :Supplier<CompletableFuture…
b96e56d 
…<T>>) operations in RedisCache.

Closes spring-projects#2650
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Oct 3, 2023
@jxblum
Implement retrieve(key) and retrieve(key, :Supplier<CompletableFuture…
35f1053 
…<T>>) operations in RedisCache.

Closes spring-projects#2650
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Oct 4, 2023
@jxblum
Implement retrieve(key) and retrieve(key, :Supplier<CompletableFuture…
a047d0c 
…<T>>) Cache operations in RedisCache.

Closes spring-projects#2650
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Oct 4, 2023
@jxblum
[OPTIONAL] Implement retrieve(key) and retrieve(key, Supplier<Complet…
5315fa7 
…ableFuture<T>> Cache operations without Jedis support.

Closes spring-projects#2650
mp911de pushed a commit that referenced this issue Oct 10, 2023
@jxblum @mp911de
Support asynchronous Cache.retrieve(…) in RedisCache.
3b62e12 
Closes #2650
@mp911de mp911de linked a pull request Oct 10, 2023 that will close this issue
Add support for asynchronous retrieval from RedisCache #2717
Closed
@mp911de mp911de changed the title Add reactive types support to RedisCache Adds support for asynchronous retrieval from RedisCache Oct 10, 2023
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Oct 12, 2023
@jxblum
Applly additional polish to Async Caching.
aae323b 
Cleanup ambigious, unreadable, unstructured and overly complex code in DefaultRedisCacheWriter.

Split RedisCacheTests.retrieveCacheValueUsingJedis() test logic by test case.

Edit Javadoc.

See spring-projects#2650
Original pull request: spring-projects#2717
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Oct 12, 2023
@jxblum
Support asynchronous Cache.retrieve(…) in RedisCache.
fab4931 
Closes spring-projects#2650
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Oct 12, 2023
@jxblum
Applly additional polish to Async Caching.
dbe7a07 
Cleanup ambigious, unreadable, unstructured and overly complex code in DefaultRedisCacheWriter.

Split RedisCacheTests.retrieveCacheValueUsingJedis() test logic by test case.

Edit Javadoc.

See spring-projects#2650
Original pull request: spring-projects#2717
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Oct 12, 2023
@jxblum
Apply additional polishing to Async Caching support.
afda3e9 
Cleanup ambigious, unreadable, unstructured and complex logic in DefaultRedisCacheWriter.

Split RedisCacheTests.retrieveCacheValueUsingJedis() test logic by test case.

Edit Javadoc.

See spring-projects#2650
Original pull request: spring-projects#2717
jxblum pushed a commit to jxblum/spring-data-redis that referenced this issue Oct 12, 2023
@mp911de @jxblum
Polishing.
10a21bb 
Replace blocking lock wait with non-blocking flow. Add support for asynchronous storage to persist the cache value after retrieval from the value supplier. Introduce AsyncCacheWriter abstraction to improve functional guards.

Reformat code. Remove redundant tests. Revisit deprecation notices with consistent mention of the version in which the deprecation was introduced.

Refine exception messages when RedisCache does not support async retrieval.

See spring-projects#2650
Original pull request: spring-projects#2717
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Oct 12, 2023
@jxblum
Apply additional polishing to Async Caching support.
0a11f3b 
Cleanup ambigious, unreadable, unstructured and complex logic in DefaultRedisCacheWriter.

Split RedisCacheTests.retrieveCacheValueUsingJedis() test logic by test case.

Edit Javadoc.

See spring-projects#2650
Original pull request: spring-projects#2717
@jxblum jxblum closed this as completed in 3dac68f Oct 12, 2023
@mp911de mp911de changed the title Adds support for asynchronous retrieval from RedisCache Add support for asynchronous retrieval from RedisCache Oct 13, 2023
@mp911de mp911de added this to the 3.2 RC1 (2023.1.0) milestone Oct 13, 2023
mp911de pushed a commit that referenced this issue Oct 13, 2023
@jxblum @mp911de
Support asynchronous Cache.retrieve(…) in RedisCache.
a72c426 
Closes #2650
Original pull request: #2717
mp911de added a commit that referenced this issue Oct 13, 2023
@mp911de
Polishing.
efc9ecf 
Replace blocking lock wait with non-blocking flow. Add support for asynchronous storage to persist the cache value after retrieval from the value supplier. Introduce AsyncCacheWriter abstraction to improve functional guards.

Reformat code. Remove redundant tests. Revisit deprecation notices with consistent mention of the version in which the deprecation was introduced.

Refine exception messages when RedisCache does not support async retrieval.

See #2650
Original pull request: #2717
@jxblum jxblum mentioned this issue Oct 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jxblum jxblum

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.2 RC1 (2023.1.0)
Development

Successfully merging a pull request may close this issue.

Add support for asynchronous retrieval from RedisCache spring-projects/spring-data-redis
3 participants
@mp911de @christophstrobl @jxblum