Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify afterPropertiesSet() Method in RedisTemplate Using Objects.requireNonNullElse #3004

Closed
wants to merge 2 commits into from
Closed

Simplify afterPropertiesSet() Method in RedisTemplate Using Objects.requireNonNullElse #3004

wants to merge 2 commits into from

Conversation

kjb512
Copy link

@kjb512 kjb512 commented Sep 23, 2024 •
edited
Loading

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes #3003

@kjb512 kjb512 changed the title Simplify afterPropertiesSet() Method in 'RedisTemplate' Using Objects.requireNonNullElse Simplify afterPropertiesSet() Method in RedisTemplate Using Objects.requireNonNullElse Sep 23, 2024
@kjb512 kjb512 marked this pull request as ready for review September 23, 2024 01:15
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 23, 2024
@mp911de
Copy link
Member

mp911de commented Sep 23, 2024

I do not share your perspective that the code is simpler to read when using Objects.requireNonNullElseGet, especially in the context of nesting Objects.requireNonNullElseGet(…) inside another instance. Primarily, the representation is different and doesn't represent what we're usually doing.

That being said, making things just different increases the mental requirements to parse the code resulting in harder to read code.

Therefore, I'm closing the ticket without applying the suggestion.

@mp911de mp911de closed this Sep 23, 2024
@mp911de mp911de added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify afterPropertiesSet() Method in RedisTemplate Using Objects.requireNonNullElse
3 participants
@kjb512 @mp911de @spring-projects-issues