Too slow for vscode after upgrading to 1.11

[lucastheisen]

I just upgraded to go 1.11, and now running goreturns takes more than the allowed 750 milliseconds:

PS C:\Users\ltheisen\git\caasd-pd-cli> (Measure-Command { goreturns -w .\cmd\build.go }).TotalSeconds
0.883458

By comparison, gofmt takes little over a tenth of a second:

PS C:\Users\ltheisen\git\caasd-pd-cli> (Measure-Command { gofmt -w .\cmd\build.go }).TotalSeconds
0.1115598

This is for a very simple file containing a single import:

package cmd

import (
	"fmt"

	"github.com/spf13/cobra"
)

func init() {
	rootCmd.AddCommand(buildCmd)
}

var buildCmd = &cobra.Command{
	Use:   "build",
	Short: "Build one or more containers",
	Run: func(cmd *cobra.Command, args []string) {
		fmt.Print("not yet implemented")
	},
}

I'm currently running go version go1.11 windows/amd64.

[lucastheisen]

Might be related to this issue, but not sure if this project uses goimports or just implements similar features...

[sqs]

This is because goreturns must typecheck, but goimports and gofmt only need to parse. It needs to typecheck because a statement like return foo() could be returning a single value or multiple values, depending on whether foo returns a single value or multiple values. That's a rare case, and I am considering just making it not fix any return f() statements. That would eliminate the need to typecheck.