Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model setters with optional values (nullable) #94

Open
stefandoorn opened this issue Jul 1, 2019 · 1 comment
Open

Model setters with optional values (nullable) #94

stefandoorn opened this issue Jul 1, 2019 · 1 comment
Milestone

Comments

@stefandoorn
Copy link
Owner

I think we should get rid of this kind of setter parameters:

  public function setter(?string value): void;

If such setters still exist after #92, we might make it non-nullable. Either provide a string, or not use the setter at all in the implementation layer.

@stefandoorn stefandoorn added this to the v2.0 milestone Jul 1, 2019
@loevgaard
Copy link
Collaborator

See my response in #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants