Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement timing conversion #4

Open
f3flight opened this issue Jan 13, 2018 · 2 comments
Open

Implement timing conversion #4

f3flight opened this issue Jan 13, 2018 · 2 comments

Comments

@f3flight
Copy link

Hi Stephen! I'm embedding this lib into my midi-related project, and I came up with the need to render a timeline of events from a midi file. This is easy if the midi file is timestamp-based, but for bpm-based timing it gets tricky, especially if tempo changes throughout the file. I think it would be great if a function is added to convert MidiSequence timing format from ticks to absolute timestamps. I understand this is a lossy operation, but still a great feature is some cases. If I happen to do this myself I will submit a review, though I'm not sure I'll be able to make this in a robust fashion. At least sharing the idea is already a good step :)

@f3flight
Copy link
Author

I've made an implementation of this (at least for Type.One midi), will send a pull request.

@f3flight
Copy link
Author

Created #5, please have a look @stephentoub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant