-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Env dependant tag creation #25
Conversation
Also working on Mac :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes look good overall. Do you know if there are any other runtimes that will need custom behavior like .NET?
// there is a special way to publishing a tag for .net5.0 | ||
const envPick = await window.showQuickPick( | ||
[".net5.0", "other"], | ||
{ placeHolder: "Select runtime" } | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a good way to detect automatically if they are using .NET? If so, we might be able to skip this prompt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we could. We could chek if there is a *.csproj in the folder. Then the prject is using .NET
Now project can be using Net3.1 or Net5.0, there we would need to read the *.csproj and find out what version it is from there :(
I've checked it quickly from demos: deno: nodejs: kotlin: java: dart: php: But from documentation it seems that some steps are necesarry for package-manager runtimes: python(already included): dart: deno: ruby: SOOO, in short. Most runtimes have some custom stuff :D but someone would have to test it |
Hello :D
So I wanted to have .net tag creation that i implemented it myself :D
The code could be improved Im pretty sure. For now I've had the occasion to test it on Windows.
Test for Mac could be nice. - Ill do it on 17.08
Im pretty shitty with js/ts.
So to publish and generate the tar that I wanted and to replicate the steps I've used 'child process' instead of using some libraries/pacakges.
If its a good way to do this I do not know.
Also, to make things easier for me I've added 1 more step in tag creation -> runtime selection, with this it could be made possible to get more ways for creating tags for other runtimes. Automatic discovery of runtime could be faulty.
And I was to lazy to do this.
If You have some ideas/code changes feel free :D