Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broker credentials should be made available as a mounted secret #301

Closed
Tracked by #56
skitt opened this issue Dec 2, 2021 · 0 comments · Fixed by #300
Closed
Tracked by #56

Broker credentials should be made available as a mounted secret #301

skitt opened this issue Dec 2, 2021 · 0 comments · Fixed by #300

Comments

@skitt
Copy link
Member

skitt commented Dec 2, 2021

Currently, broker credentials are passed in the environment. Instead, they should be provided as mounted secrets.

This is part of submariner-io/enhancements#56
@skitt skitt self-assigned this Dec 2, 2021
@skitt skitt transferred this issue from submariner-io/submariner Dec 16, 2021
skitt added a commit to skitt/admiral that referenced this issue Dec 16, 2021
@skitt
Read broker token and CA from a mounted secret
87cbc7f 
Fixes: submariner-io#301
Signed-off-by: Stephen Kitt <[email protected]>
This was referenced Dec 16, 2021
Closed
Merged
tpantelis pushed a commit that referenced this issue Dec 16, 2021
@skitt @tpantelis
Read broker token and CA from a mounted secret
d630c38 
Fixes: #301
Signed-off-by: Stephen Kitt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Read broker token and CA from a mounted secret skitt/admiral
1 participant
@skitt