Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI job for OVN IC #209

Open
aswinsuryan opened this issue Aug 9, 2023 · 8 comments · Fixed by submariner-io/shipyard#1338
Open

Add CI job for OVN IC #209

aswinsuryan opened this issue Aug 9, 2023 · 8 comments · Fixed by submariner-io/shipyard#1338

Comments

@aswinsuryan
Copy link
Contributor

aswinsuryan commented Aug 9, 2023

Add a CI job for OVN IC deployment

For OVN IC single node per zone deployments we need to change the command here to
delete_cluster_on_fail ./ovn-kubernetes/contrib/kind.sh -ov "$OVN_IMAGE" -cn "${KIND_CLUSTER_NAME}" -ric -ic -npz 1 -wk 3 -lr -dd "${KIND_CLUSTER_NAME}.local"

we can maintain ovn-ic and non-ic deployment jobs for a while . So shipyard needs to be enhanced to add a new option like

make clusters using=ovn-ic

It is observed that OVN CI does not push latest images to quay so it would be more appropriate for Submariner to always build the image from the ovn kubernetes code we download

We can use the below steps to build the code and use it.

mkdir -p $HOME/work/src/github.com/ovn-org
cd $HOME/work/src/github.com/ovn-org
git clone https://github.com/ovn-org/ovn-kubernetes
cd $HOME/work/src/github.com/ovn-org/ovn-kubernetes/dist/images


# Build ovn docker image
pushd ../../go-controller
make
popd

# Build ovn kube image
# Find all built executables, but ignore the 'windows' directory if it exists
find ../../go-controller/_output/go/bin/ -maxdepth 1 -type f -exec cp -f {} . \;
echo "ref: $(git rev-parse  --symbolic-full-name HEAD)  commit: $(git rev-parse  HEAD)" > git_info

OVN_IMAGE=<registry>/ovn-daemonset-f:latest
docker build -t $OVN_IMAGE -f Dockerfile.fedora . 
docker push $OVN_IMAGE
@aswinsuryan aswinsuryan mentioned this issue Aug 9, 2023
25 tasks
@dfarrell07 dfarrell07 moved this to In Progress in Submariner 0.16 Aug 9, 2023
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 10, 2023
Fixes: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 10, 2023
Fixes: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 10, 2023
Fixes: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 10, 2023
Fixes: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 14, 2023
Fixes: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 14, 2023
Fixes: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 14, 2023
Fixes: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 14, 2023
Fixes: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 14, 2023
Fixes: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 14, 2023
Fixes: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 14, 2023
Fixes: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 14, 2023
Fixes: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 14, 2023
Fixes: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 14, 2023
Fixes: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 14, 2023
Fixes: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 15, 2023
Fixes: submariner-io/enhancements#209
Co-authored-by: Mike Kolesnik <[email protected]>
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 15, 2023
Fixes: submariner-io/enhancements#209
Co-authored-by: Mike Kolesnik <[email protected]>
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue Aug 15, 2023
Fixes: submariner-io/enhancements#209
Co-authored-by: Mike Kolesnik <[email protected]>
Signed-off-by: Daniel Farrell <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Submariner 0.16 Aug 15, 2023
@dfarrell07 dfarrell07 reopened this Aug 15, 2023
@aswinsuryan
Copy link
Contributor Author

yes Operator, submariner and lighthouse.

We don't currently test Lighthouse with OVN. I suspect we didn't think there would be unique interactions between Lighthouse and the CNI to test. If that's wrong, let me know and I'll add OVN coverage to Lighthouse.

There's some breakage in OVN CI (unrelated to this) that's being sorted out by a series of changes. Currently looking past those issues and verifying IC for operator and main repo here:

dfarrell07/submariner-operator#225 dfarrell07/submariner#57

ok , may be it is worth adding in subctl ? I see a recent PR missed an issue since OVN job was not run.

dfarrell07 added a commit to dfarrell07/subctl that referenced this issue Aug 16, 2023
This will be removed once we're ready to default to OVN IC.

Relates-to: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
@dfarrell07
Copy link
Member

ok , may be it is worth adding in subctl ? I see a recent PR missed an issue since OVN job was not run.

Cool, good idea. Testing here: dfarrell07/subctl#77

@dfarrell07
Copy link
Member

@aswinsuryan Is there a good way to check if IC mode is actually enabled/running?

@aswinsuryan
Copy link
Contributor Author

@aswinsuryan Is there a good way to check if IC mode is actually enabled/running?

To check manually or on code ?

If we do kubectl get nodes -o yaml | grep zone we should be able to see zone configuration

@dfarrell07
Copy link
Member

dfarrell07 commented Aug 23, 2023

Comparing the two deployments, I see OVN non-IC has k8s.ovn.org/zone-name: global whereas OVN IC has k8s.ovn.org/remote-zone-migrated: cluster1-worker2 and k8s.ovn.org/zone-name: cluster1-worker2. So I guess if the zone-name label exists and is not global we can assume it's OVN IC.

skitt pushed a commit to skitt/shipyard that referenced this issue Sep 19, 2023
Fixes: submariner-io/enhancements#209
Co-authored-by: Mike Kolesnik <[email protected]>
Signed-off-by: Daniel Farrell <[email protected]>
skitt pushed a commit to skitt/shipyard that referenced this issue Sep 19, 2023
Fixes: submariner-io/enhancements#209
Co-authored-by: Mike Kolesnik <[email protected]>
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/submariner-operator that referenced this issue Sep 20, 2023
This will be removed once we're ready to default to OVN IC.

Relates-to: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
skitt pushed a commit to skitt/shipyard that referenced this issue Oct 4, 2023
Fixes: submariner-io/enhancements#209
Co-authored-by: Mike Kolesnik <[email protected]>
Signed-off-by: Daniel Farrell <[email protected]>
skitt pushed a commit to skitt/shipyard that referenced this issue Oct 4, 2023
Fixes: submariner-io/enhancements#209
Co-authored-by: Mike Kolesnik <[email protected]>
Signed-off-by: Daniel Farrell <[email protected]>
skitt pushed a commit to skitt/shipyard that referenced this issue Oct 4, 2023
Fixes: submariner-io/enhancements#209
Co-authored-by: Mike Kolesnik <[email protected]>
Signed-off-by: Daniel Farrell <[email protected]>
skitt pushed a commit to skitt/shipyard that referenced this issue Oct 4, 2023
Fixes: submariner-io/enhancements#209
Co-authored-by: Mike Kolesnik <[email protected]>
Signed-off-by: Daniel Farrell <[email protected]>
sridhargaddam pushed a commit to submariner-io/shipyard that referenced this issue Oct 4, 2023
Fixes: submariner-io/enhancements#209
Co-authored-by: Mike Kolesnik <[email protected]>
Signed-off-by: Daniel Farrell <[email protected]>
skitt pushed a commit to submariner-io/shipyard that referenced this issue Oct 5, 2023
Fixes: submariner-io/enhancements#209
Co-authored-by: Mike Kolesnik <[email protected]>
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/submariner-operator that referenced this issue Nov 22, 2023
This will be removed once we're ready to default to OVN IC.

Relates-to: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/submariner-operator that referenced this issue Nov 22, 2023
This will be removed once we're ready to default to OVN IC.

Relates-to: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
@maayanf24 maayanf24 added this to Backlog Jul 2, 2024
@maayanf24 maayanf24 moved this to Backlog in Backlog Jul 2, 2024
@tpantelis tpantelis moved this from Backlog to Next Version Candidate in Backlog Oct 28, 2024
@tpantelis tpantelis removed this from Backlog Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants